Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ControllerMessenger to Messenger, RestrictedControllerMessenger to RestrictedMessenger #4538

Open
mcmire opened this issue Jul 17, 2024 · 0 comments

Comments

@mcmire
Copy link
Contributor

mcmire commented Jul 17, 2024

Following the ADR "Messaging Non-Controllers", we want to rename the controller messenger such that consumers are not deterred from using it for non-controllers.

Acceptance Criteria

  • ✅ The ControllerMessenger class is renamed to Messenger
  • ✅ The RestrictedControllerMessenger class is renamed to RestrictedMessenger
  • ❌ No other references to the "controller messenger" are updated (e.g. names of controller messenger types, variable names, etc.) It still makes sense to use the term "controller messenger" in cases where we have a messenger for a controller, which is the vast majority of cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants