Fix warning on second currentProvider access
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expose the `currentProvider` property on our shim as a deprecated way to access to provider, to make the task of migrating dapps away from our injected web3 instance easier. The intent was to warn if that property is used, but log an error to the console and inform MetaMask if any other property is used. There was a mistake in the logic that caused us to treat subsequent accesses to `currentProvider` to be treated like some unsupported property was being accessed. This results in the console error being shown erroneously, it bloats our web3 usage metrics, and it causes the warning about web3 usage to appear unnecessarily in the MetaMask UI. The logic has been updated to never treat `currentProvider` as an unsupported property. Accessing that property will only result in a deprecation warning.
|
This was reported here: MetaMask/metamask-extension#10356 |
kumavis
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose the
currentProviderproperty on our shim as a deprecated way to access to provider, to make the task of migrating dapps away from our injected web3 instance easier. The intent was to warn if that property is used, but log an error to the console and inform MetaMask if any other property is used.There was a mistake in the logic that caused us to treat subsequent accesses to
currentProviderto be treated like some unsupported property was being accessed. This results in the console error being shown erroneously, it bloats our web3 usage metrics, and it causes the warning about web3 usage to appear unnecessarily in the MetaMask UI.The logic has been updated to never treat
currentProvideras an unsupported property. Accessing that property will only result in a deprecation warning.