Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HD path option m/44'/60'/0'/0 for Ledger wallets. #6716

Closed
Roger-Wu opened this issue Jun 15, 2019 · 5 comments · Fixed by #9367
Closed

Add HD path option m/44'/60'/0'/0 for Ledger wallets. #6716

Roger-Wu opened this issue Jun 15, 2019 · 5 comments · Fixed by #9367

Comments

@Roger-Wu
Copy link

What problem are you trying to solve?

When adding accounts from a Ledger wallet, there are 2 options for the HD path,

  • Ledger Live: m/44'/60'/0'/0/0
  • Legacy (MEW / MyCrypto): m/44'/60'/0'

But we have been using m/44'/60'/0'/0 for more than 1 year, and we believe that it is a commonly used path and should be one of the options too.

Describe the solution you'd like

Update the getHdPaths function in ui/app/pages/create-account/connect-hardware/account-list.js to something like

    getHdPaths () {
      return [
        {
          label: `Ledger Live`,
          value: `m/44'/60'/0'/0/0`,
        },
        {
          label: `Legacy (BIP44)`,
          value: `m/44'/60'/0'/0`,
        },
        {
          label: `Legacy (MEW / MyCrypto)`,
          value: `m/44'/60'/0'`,
        },
      ]
    }

selectPathHelp in app/_locales/en/messages.json should be updated too.

The label Legacy (BIP44) may not be an optimal one, but we don't know how to make it better. Please give us some suggestions if you have any.

Additional context

A screenshot in MetaMask 6.6.1.
image

@vondra
Copy link

vondra commented May 10, 2021

I moved from Ledger to Trezor. I need to connect to m/44'/60'/0' addresses.
When I connect Trezor is there a option how to manualy set derivation path or invoke the path selector ?

@jpangelle
Copy link

I moved from Ledger to Trezor. I need to connect to m/44'/60'/0' addresses.
When I connect Trezor is there a option how to manualy set derivation path or invoke the path selector ?

Also having this same issue.

@stanislavkozlovski
Copy link

Ditto, we need a way to set dpath

@xGitter
Copy link

xGitter commented Sep 21, 2021

Any news? I have the same problem. I'm trying to migrate from Ledger to Trezor, so I need to change the derivation path to m/44'/60'/0'

@Stanislav144
Copy link

Ditto, we need a way to set dpath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants