Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global initialization event #31

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Add global initialization event #31

merged 4 commits into from
Apr 20, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Apr 14, 2020 •
edited
Loading

  • Adds a global initialization event for asynchronous injection: ethereum#initialized
  • Restructures the repo and the module's exports

@rekmarks rekmarks force-pushed the init-event branch 4 times, most recently from 9b420c7 to 4553876 Compare April 14, 2020 20:09
Gudahtt
Gudahtt requested changes Apr 17, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the version bump to a separate PR?

@rekmarks rekmarks requested a review from Gudahtt April 17, 2020 22:02
@rekmarks
Copy link
Member Author

@Gudahtt done

Gudahtt
Gudahtt previously approved these changes Apr 17, 2020
View reviewed changes
@Gudahtt Gudahtt dismissed their stale review April 17, 2020 22:08

I wasn't sure what that button did

@rekmarks
add global initialization event
b29b6e9 
return provider from initProvider
Gudahtt
Gudahtt requested changes Apr 18, 2020
View reviewed changes
src/MetamaskInpageProvider.js Outdated Show resolved Hide resolved
src/initProvider.js Outdated Show resolved Hide resolved
@rekmarks rekmarks mentioned this pull request Apr 18, 2020
Merged
@rekmarks rekmarks requested a review from Gudahtt April 18, 2020 17:10
Gudahtt
Gudahtt approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit ea0b419 into master Apr 20, 2020
@rekmarks rekmarks deleted the init-event branch April 20, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt