Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Swaps confirmation screen lags when swapping ETH <> ERC20 #11513

Open
cortisiko opened this issue Sep 30, 2024 · 0 comments
Open

[Bug]: Swaps confirmation screen lags when swapping ETH <> ERC20 #11513

cortisiko opened this issue Sep 30, 2024 · 0 comments
Labels
regression-prod-7.31 Regression bug that was found in production in release 7.31 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps type-bug Something isn't working

Comments

@cortisiko
Copy link
Member

Describe the bug

There is a recent slowdown when submitting swap transactions, in particular ETH <> ERC20. In my case i swapped ETH <> DAI and i noticed that the app hangs on the swap confirmation view for a few seconds before transitioning to the wallet view. This makes swapping feels a bit sluggish. Furthermore, this behavior has introduced flakiness without our e2e tests.

Expected behavior

The swaps confirmation screen should automatically dismiss after a brief period. On slower devices, extended display time may lead users to believe the app has frozen, causing frustration and potentially prompting them to unnecessarily restart the app to retry the swap.

Screenshots/Recordings

Here is my manual run through
https://github.com/user-attachments/assets/45ad11e2-cdd3-412e-8ea9-f81ad13c3e78

Here is the automated test run: https://app.screencast.com/HlxFlYi09fLNO

Steps to reproduce

Go to mainnet
swap ETH <> ERC or swap ERC20 <> ERC20
Notice on the swaps confirmation screen the app hangs for a bit before transitioning to the wallet view

Error messages or log output

No response

Detection stage

In production (default)

Version

7.31

Build type

None

Device

Android 14, iOS 18

Operating system

iOS, Android

Additional context

No response

Severity

No response

@cortisiko cortisiko added type-bug Something isn't working Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps labels Sep 30, 2024
@metamaskbot metamaskbot added the regression-prod-7.31 Regression bug that was found in production in release 7.31 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-7.31 Regression bug that was found in production in release 7.31 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants