Move helper functions to simulation package #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
=======================================
Coverage 94.40% 94.41%
=======================================
Files 480 482 +2
Lines 10244 10261 +17
Branches 1563 1563
=======================================
+ Hits 9671 9688 +17
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/move-helpers-to-simulation
branch
from
5b872a1
to
7ea67cc
Compare
GuillaumeRx
approved these changes
Sep 27, 2024
Mrtenz
force-pushed
the
mrtenz/move-helpers-to-simulation
branch
from
7ea67cc
to
24e81c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the simulation package easier to work with, I've moved all the helper functions (
request,onTransaction, etc.) to the simulation package.There are no functional changes in this PR, it just moves code around.