Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add derivation logs in the summary #368

Open
lucasew opened this issue Oct 14, 2023 · 2 comments
Open

Suggestion: add derivation logs in the summary #368

lucasew opened this issue Oct 14, 2023 · 2 comments

Comments

@lucasew
Copy link
Contributor

lucasew commented Oct 14, 2023

I, at least, have the habit of when a a PR settles I run this to check if that works on my machine is not happening but sometimes the build fails and it only posts if a package is failed or successfully built without any kind of logs.

My suggestion is to add the logs using summary/details so the logs are hidden by default but still acessible when the summary is posted.

But there are some concerns:

  • How it will look in notification emails?
  • Do GitHub have some kind of body limit when submitting a PR comment?
  • Isn't it wiser to post the logs using a gist as ofborg sometimes do? (suggestion: all logs for a PR in the same gist using different files)

The link with related information about this summary/details thing: https://gist.github.com/scmx/eca72d44afee0113ceb0349dd54a84a2

@Mic92
Copy link
Owner

Mic92 commented Oct 14, 2023

I am bit concerned that we abuse gist as a ci pastebin service. Unlike other pastebins they store logs forever. Just now it's only ofborg itself but this would multiple the number of logs done by individuals. What I could imagine is to store the last 25 lines per failed build in a summary and have a limit how many failed builds to include in this report.

@lucasew
Copy link
Contributor Author

lucasew commented Oct 14, 2023

Seems fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants