Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Request-Dependency correlation is broken #340

Closed
kartang opened this issue Jan 31, 2017 · 2 comments
Closed

Request-Dependency correlation is broken #340

kartang opened this issue Jan 31, 2017 · 2 comments

Comments

@kartang
Copy link
Contributor

kartang commented Jan 31, 2017

Operation id of the request is not propagated to the child dependencies. Please find the following example:
image
@SergeyKanzhelev SergeyKanzhelev mentioned this issue Feb 5, 2017
Merged
@pharring
Copy link
Member

pharring commented Feb 6, 2017

Sergey asked me to look into fixing this.

Am I right in thinking that we expect behavior for the dependency to look like this:
Operation Id: 80000032-0001-f000-b63f-84710c796bb
Operation name: GET Benchmark/HttpDependencyParallelCalls
Dependency Id: qOwUmMlhB00=
DeveloperMode: true
?

Also, if the Request's Operation Id is blank, then should the dependency's Operation Id be taken from the "Request Id" instead?

@SergeyKanzhelev
Copy link
Contributor

yes, this would be great. The main issue with correlation is that .Context.Operation.Id should be shared across all items. item.Id should be unique. And .Context.Operation.ParentId should point to the parent. In the example @kartang posted dependency's Operation.Context.Id was used as a ParentId

dnduffy pushed a commit that referenced this issue Feb 16, 2017
@pharring @dnduffy
Allow simultaneous overlapping requests in HostingDiagnosticListener (#…
3567c4a 
…343)

* Add tests to illustrate issue #342
* Fix issue #342
* Incorporate review feedback:
Set timestamp in OnBeginRequest.
Add a test for issue #340
Set Id instead of OperationId (Fixes #340)

* Add test for issue #333
* Implement OperationCorrelationTelemetryInitializer
Fixes issue #333

* Use UTC for start time epoch
* Use Start()/Stop() extension methods
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SergeyKanzhelev @pharring @kartang