This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Operation IDs are being duplicated under load #342
Labels
Comments
dnduffy
pushed a commit
that referenced
this issue
Feb 16, 2017
…343) * Add tests to illustrate issue #342 * Fix issue #342 * Incorporate review feedback: Set timestamp in OnBeginRequest. Add a test for issue #340 Set Id instead of OperationId (Fixes #340) * Add test for issue #333 * Implement OperationCorrelationTelemetryInitializer Fixes issue #333 * Use UTC for start time epoch * Use Start()/Stop() extension methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I notice that, under load, my ASP.NET Core website generates request telemetry with duplicate Operation IDs.
It appears that HostingDiagnosticListener isn't written with multiple simultaneous requests in mind.
In particular,
this.client.Context.Operation.Idgets overwritten by each new request (line 44)(Also
beginRequestTimestamp)Rather that setting the Operation ID in the client's context (which is like setting it globally), I believe it should be set in the
RequestTelemetryobject that is added toHttpContext.FeaturesOne would think that the timestamp could also be recorded in the RequestTelemetry object (indeed it already has fields for recording start time, so it's odd that it's not initialized here)
The text was updated successfully, but these errors were encountered: