Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Remove the use of Platform Abstractions #410

Closed
SergeyKanzhelev opened this issue Apr 27, 2017 · 3 comments
Closed

Remove the use of Platform Abstractions #410

SergeyKanzhelev opened this issue Apr 27, 2017 · 3 comments
Labels
Milestone

Comments

@Dmitry-Matveev
Copy link
Member

@Eilon, is it something you think needs to be fixed for light-up scenario?

Without this fix, in Core 2.0:

  • in the best case, the app name will be "Undefined + exception message" in the AI tracing events.
  • in the worst case, if this runtime exception is not caught by some reason (although, it should not be), it'll be an crash in event source constructor.

The current version of AI ASP.NET Core SDK on Nuget.org has this Platform Abstraction dependency and as far as I know your team has already referenced that version of AI ASP.NET Core SDK for your scenarios (which might involve Core 2.0).

@Dmitry-Matveev Dmitry-Matveev added this to the 2.1 milestone May 1, 2017
@SergeyKanzhelev
Copy link
Contributor Author

CC: @glennc @qubitron

@Eilon
Copy link
Member

Eilon commented May 3, 2017

I think it's good to fix this no matter what because that package no longer provides any real value.

I'm not sure how it would block the light-up scenarios specifically, though, because ultimately it's "just a package, so in theory it would just work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants