Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Enable Azure Search Parser #1048

Closed
TsuyoshiUshio opened this issue Oct 17, 2018 · 7 comments
Closed

Enable Azure Search Parser #1048

TsuyoshiUshio opened this issue Oct 17, 2018 · 7 comments
Milestone

Comments

@TsuyoshiUshio
Copy link

Hello, This is not an issue.

We'd like to add Azure Search Parser. If you guys are OK, we'd like to contribute with @k-miyake and @shibayan .

https://github.com/Microsoft/ApplicationInsights-dotnet-server/tree/develop/Src/DependencyCollector/Shared/Implementation/HttpParsers

Do you know if someone is working on this?

@lmolkova
Copy link
Member

@TsuyoshiUshio nobody should be working on this.

@SergeyKanzhelev, @Dmitry-Matveev I remember we have additional logic on Breeze to parse dependency kinds. Do you think it makes sense to enable Azure Search dependency type parser in .NET SDK or we'd rather change Breeze to support all SDKs?

@SergeyKanzhelev
Copy link
Contributor

@lmolkova it is important to implement this logic in the layer that does pre-aggregation. Application Insights endpoint is a last resort in that case for SDKs that doesn't have any pre-aggregations. Ideally do it in SDK and than in local forwarder

@SergeyKanzhelev
Copy link
Contributor

@TsuyoshiUshio we welcome contributions! Azure Search support would be great!

@TsuyoshiUshio
Copy link
Author

Thank you, @lmolkova and @SergeyKanzhelev ! We’ll work on that with @k-miyake and @shibayan

@SergeyKanzhelev
Copy link
Contributor

@TsuyoshiUshio let us know if you need some help

@shibayan
Copy link
Contributor

I just implemented Azure Search parser. Please review my PR.

@cijothomas cijothomas added this to the 2.9-beta1 milestone Oct 25, 2018
@lmolkova
Copy link
Member

lmolkova commented Dec 4, 2018

Thanks for the contribution!

@lmolkova lmolkova closed this as completed Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants