Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Mistake on SyntheticUserAgentTelemetryInitializer.cs #750

Closed
christopheMeudec opened this issue Nov 21, 2017 · 1 comment
Closed

Mistake on SyntheticUserAgentTelemetryInitializer.cs #750

christopheMeudec opened this issue Nov 21, 2017 · 1 comment
Labels
bug
Milestone
2.5-Beta2

Comments

@christopheMeudec
Copy link

Hi,

I found a mistake by reading the code.
https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/ddbd67d40a36ec257990dc0c6e277fc226f1a9d4/Src/Web/Web.Shared.Net/SyntheticUserAgentTelemetryInitializer.cs#L62-L63

The check "request != null" have to be done before accessing to the property UserAgent.

Regards
Christophe
@TimothyMothra
Copy link
Member

@christopheMeudec Thank you!
Was this causing an exception for you?

@TimothyMothra TimothyMothra mentioned this issue Nov 21, 2017
Merged
2 tasks
@TimothyMothra TimothyMothra added this to the 2.5-Beta2 milestone Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.5-Beta2
Development

No branches or pull requests
2 participants
@christopheMeudec @TimothyMothra