This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
When Activity has root id compatible with W3C Id, use it as trace id #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MS-TimothyMothra please review |
TimothyMothra
approved these changes
Nov 30, 2018
lmolkova
pushed a commit
that referenced
this pull request
Dec 3, 2018
lmolkova
pushed a commit
that referenced
this pull request
Dec 3, 2018
* Add more ServiceBus test cases for W3C enabled scenario * Fix broken tests after merge with #1107
lmolkova
deleted the
lmolkova/reuseActivityRootIdWhenCompatibleWithW3C
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transition to W3C standard in customer distributed system starts with frontend service. The first service should generate W3C compatible operation id that could be used downstream on all services whether they support W3C or not.
This change checks
THEN is uses root id as traceid.
As a result when customer updates frontend to AppInsights 2.7+ and when it calls downstream service, it emits Request-Id = |traceId.1. and traceparent = 00-trace-id-spanId-00
This guarantees common operation id on all downstream services.