Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to start operation with pre-defined root and parent ID #163

Closed
SergeyKanzhelev opened this issue Jan 22, 2016 · 3 comments
Closed

Comments

@SergeyKanzhelev
Copy link
Contributor

StartOperaiton API doesn't support scenario when parent ID and root ID were received from different layer and we want to start operation with the existing parent and root ID.

Proposed change - allow StartOperaition to receive RequestTelemetry type as an argument

@pharring
Copy link
Member

👍 to this, but also to allow passing the root ID as a raw value rather than as a RequestTelemetry.

@SergeyKanzhelev
Copy link
Contributor Author

Why only root ID? Any significance for it?

@pharring
Copy link
Member

pharring commented Feb 11, 2017

Sure, parent ID too, optionally. It's possible the parent ID will be set via an initializer (e.g. in the case of a dependency in the context of an ASP.NET request).

i.e.

public static IOperationHolder<T> StartOperation<T>(this TelemetryClient telemetryClient, string operationName, string operationId = null, string operationParentId = null) where T : OperationTelemetry, new()
{
    ...
    operation.Telemetry.Start();

    if (!string.IsNullOrEmpty(operationId))
    {
        operation.Telemetry.Context.Operation.Id = operationId;
    }

    if (!string.IsNullOrEmpty(operationParentId))
    {
        operation.Telemetry.Context.Operation.ParentId = operationParentId;
    }

    ...

    telemetryClient.Initialize(operation.Telemetry);
    ...
}

I'll try to get a PR out for this later tonight.

pharring added a commit to pharring/ApplicationInsights-dotnet that referenced this issue Feb 11, 2017
TimothyMothra added a commit that referenced this issue Oct 25, 2019
* changelog and version. 
* update BaseSDK version 2.6.0-beta2
TimothyMothra pushed a commit that referenced this issue Oct 25, 2019
Component version telemetry initializer and associated functional test changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants