Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The netstandard1.3 'Microsoft.AI.ServerTelemetryChannel' depends on Newtonsoft.Json #800

Closed
clguiman opened this issue May 11, 2018 · 1 comment
Closed

The netstandard1.3 'Microsoft.AI.ServerTelemetryChannel' depends on Newtonsoft.Json #800

clguiman opened this issue May 11, 2018 · 1 comment
Labels
bug channel P1
Milestone
2.6

Comments

@clguiman
Copy link
Member

This dependency is a problem if you want to inject ApplicationInsights at runtime in an netcore 2.1 application.
The loading logic has changed there and might downgrade the application's Newtonsoft.Json version.
@SergeyKanzhelev
Copy link
Contributor

Dependency on third party library like Newtonsoft.Json is a problem in general. It may cause all sort of version conflicts with the customer apps.

@clguiman clguiman mentioned this issue May 14, 2018
Merged
5 tasks
clguiman added a commit to clguiman/ApplicationInsights-dotnet that referenced this issue May 15, 2018
@clguiman
Add netstandard2.0 target for ServerTelemetryChannel and remove Newto…
9e0da33 
…nsoft.Json dependency (microsoft#800)
@TimothyMothra TimothyMothra added this to the 2.6 milestone May 15, 2018
@TimothyMothra TimothyMothra mentioned this issue May 15, 2018
Merged
cijothomas added a commit that referenced this issue May 15, 2018
@cijothomas
Merge pull request #801 from clguimanMSFT/clguiman/telemetrychannel-n…
90623fb 
…etstandard2.0

Add netstandard2.0 target for ServerTelemetryChannel and remove Newtonsoft.Json dependency (#800)
cijothomas pushed a commit that referenced this issue May 15, 2018
@clguiman @cijothomas
Add netstandard2.0 target for ServerTelemetryChannel and remove Newto…
395f5dc 
…nsoft.Json dependency (#800)

(cherry picked from commit 9e0da33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug channel P1
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
3 participants
@SergeyKanzhelev @clguiman @TimothyMothra