Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics extraction to the new APIs and remove MetricManager V1 & Co #806

Closed
macrogreg opened this issue May 17, 2018 · 3 comments
Closed
Labels

Comments

@macrogreg
Copy link
Contributor

We have recent shipped new metric aggregation APIs.
However, standard metric extraction uses old internal APIs.
We need to
a) Change the extractor to use the new APIs
b) Remove the old APIs.

This will not affect any public APIs or any public configuration options. However, customers who used reflection to access V1 MetricManager APIs will be broken.

@TimothyMothra
Copy link
Member

Just to confirm, will V2 be public?
Do we need to publish any guidance for customers to migrate from V1 to V2?

@macrogreg
Copy link
Contributor Author

Yes, V2 is public, V1 is internal.
There is not guidance to migrate since V1 was internal. The extractors using V1 are public but transitioning them to V2 should not have any publicly observable effect, except a small performance improvement.

@Dmitry-Matveev
Copy link
Member

@macrogreg , I believe we can close this issue as it was successfully implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants