Response code shouldn't be overwritten to 200 if not set #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.ResponseCode = string.Empty; | ||
| } | ||
|
|
||
| if (!this.Success.HasValue) |
There was a problem hiding this comment.
This changes our current experience in UI where requests may now have value if we were not able to collect response code. However, it's correct to respect that success is set to false. Can we set request to 200 when success if true and set to success to true only if it was not set to false before?
Dmitry-Matveev
approved these changes
Sep 17, 2018
TimothyMothra
pushed a commit
that referenced
this pull request
Oct 25, 2019
…ault (#918) * make JavascriptEncoder optional parameter to prevent crash when no encoder is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue # .
In our internal 'custom requests' tracking like for Service Bus implementation we don't set response code, but set success to false and as a result success is overwritten to true and response code set to 200. It shouldn't happen in case of StartOperation as well because response code doesn't apply there.