Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1283 - opening a bot that has moved should show a message #1360

Merged
merged 5 commits into from
Mar 11, 2019
Merged

Fixes #1283 - opening a bot that has moved should show a message #1360

merged 5 commits into from
Mar 11, 2019

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Mar 7, 2019 •
edited
Loading

Fixes #1283

@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2197

  • 1 of 7 (14.29%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 54.986%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/commands/botCommands.ts 0 1 0.0%
packages/app/main/src/main.ts 0 5 0.0%
Totals Coverage Status
Change from base Build 2193: 0.009%
Covered Lines: 4873
Relevant Lines: 8322
💛 - Coveralls

a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Mar 9, 2019
View reviewed changes
@justinwilaby justinwilaby force-pushed the jwilaby/#1283-missing-file-dialog branch from ca4db39 to 9044c45 Compare March 11, 2019 14:24
a-b-r-o-w-n
a-b-r-o-w-n requested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog?

@justinwilaby justinwilaby force-pushed the jwilaby/#1283-missing-file-dialog branch from 9044c45 to 4b12ebb Compare March 11, 2019 18:07
@cwhitten cwhitten merged commit 00f263e into master Mar 11, 2019
@cwhitten cwhitten deleted the jwilaby/#1283-missing-file-dialog branch March 11, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinwilaby @coveralls @a-b-r-o-w-n @cwhitten