Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed opening a livechat session via protocol. #1446

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fixed opening a livechat session via protocol. #1446

merged 1 commit into from
Apr 23, 2019

Conversation

tonyanziano
Copy link
Contributor

Fixes #1420

@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2476

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 56.791%
Files with Coverage Reduction New Missed Lines %
packages/app/main/src/protocolHandler.ts 2 81.22%
Totals Coverage Status
Change from base Build 2472: -0.004%
Covered Lines: 5250
Relevant Lines: 8685
💛 - Coveralls

@tonyanziano tonyanziano merged commit bfdbda8 into master Apr 23, 2019
@tonyanziano tonyanziano deleted the toanzian/#1420-protocol branch April 23, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DCR] Open Emulator via url protocol. Ex: botemulator://localhost:3978/api/messages
3 participants
@tonyanziano @coveralls @justinwilaby