Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech: Microphone not respecting input hint #1328

Closed
eljodon opened this issue Nov 8, 2018 · 4 comments · Fixed by #1286
Closed

Speech: Microphone not respecting input hint #1328

eljodon opened this issue Nov 8, 2018 · 4 comments · Fixed by #1286
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing size-m 1-3 days
Milestone

Comments

@eljodon
Copy link

eljodon commented Nov 8, 2018

The microphone keeps activating and listening after a message is received, ignoring the message input hint value. This behavior is happening in the latest Chrome and Edge browsers at least.

I am using the the latest full bundle:
https://cdn.botframework.com/botframework-webchat/latest/webchat.js

@compulim
Copy link
Contributor

compulim commented Nov 9, 2018

Got it, will work on it. 😉

@compulim compulim added Approved front-burner p1 Painful if we don't fix, won't block releasing labels Nov 9, 2018
@compulim compulim added this to the v4.2 milestone Nov 9, 2018
@corinagum corinagum added 4.3 and removed 4.2 labels Nov 27, 2018
@compulim
Copy link
Contributor

@compulim compulim modified the milestones: v4.2, v4.3 Nov 28, 2018
@corinagum corinagum added the size-m 1-3 days label Dec 7, 2018
@compulim compulim modified the milestone: v4.3 Dec 18, 2018
@compulim compulim added the bug Indicates an unexpected problem or an unintended behavior. label Dec 18, 2018
@compulim
Copy link
Contributor

Need to figure out the corner case:

  • The bot send 2 successive activities after the user talk to a bot using speech
    • First incoming activity has inputHint set to expectingInput
    • Second incoming activity has inputHint set to ignoringInput
    • What is the expected behavior? Either one of the following
      • After speaking first and second activity, we should start recording, or,
      • After speaking first and second activity, we should not start recording

@corinagum
Copy link
Contributor

@lauren-mills provided very helpful input that I will copy-paste below: (emphasis mine)

The approach that seems to work best is that each message should be IgnoringInput except for the final message on a turn, which should be ExpectingInput for prompts or AcceptingInput for other messages. This approach prevents the bot from ever listening to itself and getting stuck in a feedback loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing size-m 1-3 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants