Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: Number.isNaN is not available #1626

Closed
compulim opened this issue Jan 23, 2019 · 0 comments · May be fixed by NoriMin/WebChatUI-MarkedSample#1
Closed

IE11: Number.isNaN is not available #1626

compulim opened this issue Jan 23, 2019 · 0 comments · May be fixed by NoriMin/WebChatUI-MarkedSample#1
Assignees
@compulim

Comments

@compulim
Copy link
Contributor

compulim commented Jan 23, 2019 •
edited
Loading

In some of our code, we are using Number.isNaN. For example, https://github.com/Microsoft/BotFramework-WebChat/blob/master/packages/component/src/Localization/en-US.js#L12.

I think Number.isNaN is unnecessary in this case because the argument is always a number, so the result is same as global.isNaN. And second, IE11 does not support Number.isNaN.

Another change would be date.valueOf(). According to MDN, this is equivalent to date.getTime(). So I would recommend using date.getTime() for consistency.
@compulim compulim self-assigned this Jan 23, 2019
@compulim compulim mentioned this issue Jan 23, 2019
Merged
compulim added a commit to compulim/WebChatUI-MarkedSample that referenced this issue Jan 23, 2019
@compulim
Move to master build
6fd01a3 
We have fixed [#1626](microsoft/BotFramework-WebChat#1626) in Web Chat. It will unblock your code so it no longer need to lock down on a specific version of Web Chat.
@compulim compulim mentioned this issue Jan 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Web Chat to master build compulim/WebChatUI-MarkedSample
1 participant
@compulim