Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need style option to change margins around bubbles #1837

Closed
stevospinks opened this issue Mar 25, 2019 · 3 comments
Closed

Need style option to change margins around bubbles #1837

stevospinks opened this issue Mar 25, 2019 · 3 comments
Assignees
Labels
front-burner p1 Painful if we don't fix, won't block releasing

Comments

@stevospinks
Copy link

stevospinks commented Mar 25, 2019

I'm facing this issue:

image

On the left is without any styling changes, on the right is my fixed version using this CSS rule set:

#webchat .content .row {
    margin-left: 0;
    margin-right: 0;
}

It would be great if this could be added to the style options

@stevospinks stevospinks changed the title Need style option to change bubble margins Need style option to change margins around bubbles Mar 25, 2019
@corinagum
Copy link
Contributor

Related issues: #1556 #1466

Hey @stevospinks, do you have another CSS framework or styles applied that may be causing the change in margin? On the linked issue above I believe that's what was causing the problem for users.

This seems to be an issue our users are coming across pretty consistently. @compulim I'm starting to think we should add this workaround for the benefit of our users. Can we use this thread to discuss?

@corinagum corinagum added Approved front-burner p1 Painful if we don't fix, won't block releasing and removed Pending labels Mar 25, 2019
@compulim
Copy link
Contributor

Note to implementer

  • Please add margin-left: 0 and margin-right: 0 to both Styles/CarouselFilmStrip.js and Styles/StackedLayout.js
  • Please add comments to say, from time-to-time, CSS framework break something related to element with class name "row"
    • So when we are doing CSS BEM work mentioned here, we are aware of taking these countermeasures out

@stevospinks
Copy link
Author

stevospinks commented Mar 27, 2019

@corinagum On further investigation it's Bootstrap that is causing the issue for me.

The latest version (4.3.1) creates this CSS rule set:

.row {
    display: -ms-flexbox;
    display: flex;
    -ms-flex-wrap: wrap;
    flex-wrap: wrap;
    margin-right: -15px;
    margin-left: -15px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

3 participants