Update to use the newer style of getUserMedia #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
compulim
approved these changes
Jul 4, 2018
|
Updated to include both Also include |
|
@rosskyl are you able to sign the CLA? I also need this fix in order for my application to run on Firefox. |
|
@egregius313 He has signed, I will start working on merging this PR into our next release. Stay tuned. |
The cognitive services back end updated to use window.navigator.mediaDevices.getUserMedia but this still checks for window.navigator.getUserMedia which is undefined in Firefox even though speech works.
|
@rosskyl @egregius313 This is out on Web Chat 0.14.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cognitive services back end updated to use window.navigator.mediaDevices.getUserMedia but this still checks for window.navigator.getUserMedia which is undefined in Firefox even though speech works.
/* Please update CHANGELOG.md. Under [Unreleased] section, describe your changes under 80 characters */