Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microphone button status change on narrator #1490

Merged
merged 7 commits into from
Dec 13, 2018
Merged

Microphone button status change on narrator #1490

merged 7 commits into from
Dec 13, 2018

Conversation

corinagum
Copy link
Contributor

Fix #1409

@coveralls
Copy link

coveralls commented Dec 12, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 597

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 44.65%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/SendBox/MicrophoneButton.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/component/src/Utils/TimeAgo.js 3 70.59%
packages/component/src/Utils/Timer.js 6 33.33%
Totals Coverage Status
Change from base Build 584: -0.6%
Covered Lines: 715
Relevant Lines: 1426
💛 - Coveralls

compulim
compulim reviewed Dec 12, 2018
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@corinagum corinagum merged commit 20cd624 into microsoft:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corinagum @coveralls @compulim