Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility & Icon fixes #1506

Merged
merged 11 commits into from
Dec 18, 2018
Merged

Accessibility & Icon fixes #1506

merged 11 commits into from
Dec 18, 2018

Conversation

corinagum
Copy link
Contributor

Fix #1264,
Fix #1308,
Fix #1318,
Fix #1334,
Fix #1425

  • Accessibility/Narrator fixes
  • Fix host-with-react sample fix.
  • Update Web Chat icons (Microphone, Send, Attachment, & Download)

@coveralls
Copy link

coveralls commented Dec 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 626

  • 5 of 8 (62.5%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 44.979%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Attachment/Assets/DownloadIcon.js 0 1 0.0%
packages/component/src/SendBox/Assets/MicrophoneIcon.js 1 2 50.0%
packages/component/src/Utils/AdaptiveCardBuilder.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/component/src/Utils/AdaptiveCardBuilder.ts 1 0.0%
Totals Coverage Status
Change from base Build 622: 0.05%
Covered Lines: 726
Relevant Lines: 1441
💛 - Coveralls

tonyanziano
tonyanziano approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@corinagum corinagum merged commit 2a2b3b9 into microsoft:master Dec 18, 2018
@compulim compulim mentioned this pull request Dec 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@tonyanziano tonyanziano tonyanziano approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@corinagum @coveralls @compulim @tonyanziano