Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps botframework-directlinejs in playground package #1511

Merged
merged 5 commits into from
Dec 19, 2018
Merged

Bumps botframework-directlinejs in playground package #1511

merged 5 commits into from
Dec 19, 2018

Conversation

cwhitten
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Dec 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 637

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 44.979%
Files with Coverage Reduction New Missed Lines %
packages/component/src/SendBox/Assets/MicrophoneIcon.js 1 25.0%
packages/component/src/Utils/AdaptiveCardBuilder.ts 8 0.0%
Totals Coverage Status
Change from base Build 622: 0.05%
Covered Lines: 726
Relevant Lines: 1441
💛 - Coveralls

@compulim
Copy link
Contributor

@cwhitten Can you update CHANGELOG.md to reflect this change?

compulim
compulim requested changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line to CHANGELOG.md to reference this PR.

@cwhitten
Copy link
Member Author

@compulim changelog line added, please take a look.

@compulim
Copy link
Contributor

Looks good to me.

@compulim
Copy link
Contributor

Since you also have right to merge, I will leave the last but important step to you. 😉

@cwhitten cwhitten merged commit 77d941a into master Dec 19, 2018
@cwhitten cwhitten deleted the v0.10.0-djs branch December 19, 2018 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwhitten @coveralls @compulim