Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render card without tap #1577

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Fix render card without tap #1577

merged 1 commit into from
Jan 11, 2019

Conversation

compulim
Copy link
Contributor

Fix #1576

When rendering this Chatdown file, it render a hero card without tap action and errored out.

@compulim compulim added the bug Indicates an unexpected problem or an unintended behavior. label Jan 11, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 727

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 44.939%
Totals Coverage Status
Change from base Build 707: -0.2%
Covered Lines: 730
Relevant Lines: 1450
💛 - Coveralls

@compulim compulim merged commit 1143da5 into microsoft:master Jan 11, 2019
@compulim compulim deleted the fix-card-without-tap branch January 11, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compulim @coveralls @corinagum