-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline UI - indicate slow connection and failed credentials #1679
Conversation
Pull Request Test Coverage Report for Build 941
💛 - Coveralls |
@corinagum can you provide some screenshots in the descriptions of the pull request? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one missing semicolon, but other than that looks good!
@mewa1024 @DesignPolice given that WebChat isn't a public facing name given to the Chat window, should we make the copy more generic? Take BuzzFeed's recent Zo bot. It would be odd to see "WebChat" in error/warning copy here. But I could imagine more generic copy that doesn't call out WebChat specifically. |
@cwhitten Good point. How about changing the messages to "Taking longer than usual to connect" and "Unable to connect"? @DesignPolice, thoughts? |
@cwhitten @mewa1024 @corinagum - That is true Chris, I forget that we need to be more generic with so many different uses of our product. That seems fine to me Mewa. |
I'll update the copy shortly! |
888d8cb
to
ca979fd
Compare
Update: I've updated the copy and fixed the build, but I'm having trouble getting tests to run locally so that I can update the png's for the ConnectivityStatus tests. Will check back in a bit. |
Resolves #1521
This adds a new component to the transcript that will notify the user when connectivity to the bot is taking longer than usual or has failed.
For slow connection, Web Chat will time 15 seconds before displaying the below warning:
A failed connection will be triggered when credentials are incorrect.
FAILED_CONNECTION_NOTIFICATION
andSLOW_CONNECTION_NOTIFICATION
? I'll update my PR with your changes.