Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De support #1740

Merged
merged 4 commits into from
Feb 19, 2019
Merged

De support #1740

merged 4 commits into from
Feb 19, 2019

Conversation

matmuenzel
Copy link
Contributor

extend german language support

thank you

@msftclas
Copy link

msftclas commented Feb 18, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Feb 18, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 55.152% when pulling 14eacc6 on matmuenzel:de-support into 25b2c47 on Microsoft:master.

corinagum
corinagum suggested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your changes to CHANGELOG.md. Thank you for the submission!

packages/component/src/Localization/de-DE.js Outdated Show resolved Hide resolved
@corinagum
Copy link
Contributor

Added my approval, but tests are still failing. I'll investigate what's going on today. :)

@corinagum corinagum merged commit d7affe2 into microsoft:master Feb 19, 2019
@corinagum
Copy link
Contributor

(failing test had to do with an accidental regression in Mock Bot, which has been addressed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matmuenzel @msftclas @coveralls @corinagum