Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sample for hosting WebChat in an Angular application #1813

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Adding sample for hosting WebChat in an Angular application #1813

merged 4 commits into from
Mar 14, 2019

Conversation

omarsourour
Copy link
Contributor

Fixes #1423

@corinagum
Copy link
Contributor

Looks good to me! Can you add an entry to CHANGELOG.md? Thanks for all the help.

@coveralls
Copy link

coveralls commented Mar 14, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 53.637% when pulling 33d3d91 on omsour/ng_webchat_sample_0.1 into 7dcdacb on master.

@omarsourour
Copy link
Contributor Author

@corinagum Done, added entry in ChangeLog. Please give it a look :)

@corinagum
Copy link
Contributor

Oops! Sorry Omar, a couple more things

  • could you update the samples list on the root README.md
  • update samples/README.md with same change

Otherwise, looks good and I will merge after your final commit. Sorry about that!

@omarsourour
Copy link
Contributor Author

@corinagum Done :) .. Please take a look

Also, may I ask/suggest why not have the root README.md link to the samples/README.md? :)

@corinagum
Copy link
Contributor

@omarsourour oh is there a way to automatically update one and it will update the other? If so please let me know how!

Thank you!

@omarsourour omarsourour reopened this Mar 14, 2019
@corinagum corinagum merged commit 9c217f2 into master Mar 14, 2019
@corinagum corinagum deleted the omsour/ng_webchat_sample_0.1 branch April 15, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omarsourour @corinagum @coveralls