JULY 2018 Security Update #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed buffer allows for semi arbitrary memory read write.
…script9.dll after closing WebBrowserControl - Internal.
… - Individual If attacker can force ServerAddDOMFastPathHelper to be called with bad arguments (e.g. using a separate OOB write vuln on the content process), then we will have an OOB read in JIT process, which leads us to lower a direct call to that OOB value.
… Intl - Google, Inc.
We have cleared the segment map before ArraySpecies. The ArraySpecies is re-entrant and once we have come back from you user code we may have constructed the segment map. This segment map is not valid anymore as we are doing splicing. Fixed this by Clearing the segment map.
… first before marshalling the last parameter to a FrameDisplay - Internal
…tializeDateTimeFormat - Google, Inc.
atulkatti
requested review from
jackhorton,
MikeHolman,
sigatrev,
aneeshdk,
aruneshchandra,
akroshg,
MSLaguana,
rajatd and
meg-gupta
meg-gupta
approved these changes
Jul 10, 2018
|
LGTM #Resolved |
atulkatti
commented
Jul 10, 2018
| #if ENABLE_FIXED_FIELDS | ||
| this->IsInitialized = descriptor.IsInitialized; | ||
| this->IsOnlyOneAccessorInitialized = descriptor.IsOnlyOneAccessorInitialized; |
There was a problem hiding this comment.
[CVE-2018-8291] LGTM #Resolved
atulkatti
commented
Jul 10, 2018
| { | ||
| // Setter without a getter; this is a stale entry, so ignore it | ||
| continue; | ||
| } |
There was a problem hiding this comment.
[CVE-2018-8283]: LGTM #Resolved
atulkatti
commented
Jul 10, 2018
| { | ||
| JavascriptError::ThrowTypeError(scriptContext, JSERR_DetachedTypedArray); | ||
| } | ||
|
|
||
| //10. Let O be OrdinaryCreateFromConstructor(NewTarget, "%DataViewPrototype%", [[DataView]], [[ViewedArrayBuffer]], [[ByteLength]], [[ByteOffset]]). |
There was a problem hiding this comment.
[CVE-2018-8280] LGTM #Resolved
sigatrev
approved these changes
Jul 10, 2018
atulkatti
commented
Jul 10, 2018
| // is kept alive until this callback completes. Any pending timer is killed in the thread service destructor so we should not get | ||
| // any new callbacks after the thread service is destroyed. | ||
| AutoAddRefReleaseThreadService autoThreadServiceKeepAlive(this); | ||
|
|
There was a problem hiding this comment.
[CVE-2018-8287] LGTM #Resolved
kfarnung
approved these changes
Jul 10, 2018
atulkatti
commented
Jul 10, 2018
| @@ -1543,7 +1536,7 @@ DEFINE_ISXLOCALEAVAILABLE(PR, uloc) | |||
| } | |||
|
|
|||
| state->SetInternalProperty( | |||
| InternalPropertyIds::HiddenObject, | |||
| InternalPropertyIds::CachedUNumberFormat, | |||
There was a problem hiding this comment.
CachedUNumberFormat [](start = 33, length = 19)
[CVE-2018-8298] LGTM #Resolved
atulkatti
commented
Jul 10, 2018
| @@ -283,6 +283,7 @@ DECLSPEC_GUARDIGNORE _NOINLINE intptr_t GetNonTableMethodAddress(ThreadContextI | |||
| ///---------------------------------------------------------------------------- | |||
| intptr_t GetMethodOriginalAddress(ThreadContextInfo * context, JnHelperMethod helperMethod) | |||
| { | |||
| AssertOrFailFast(helperMethod >= 0 && helperMethod < IR::JnHelperMethodCount); | |||
There was a problem hiding this comment.
AssertOrFailFast [](start = 4, length = 16)
[CVE-2018-8276] LGTM #Resolved
dilijev
approved these changes
Jul 10, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jul 10, 2018
Merge pull request #5444 from atulkatti:servicing/1807_1.10 JULY 2018 Security Update that addresses the following issues in ChakraCore.dll: [CVE-2018-8275], [CVE-2018-8276], [CVE-2018-8279], [CVE-2018-8280], [CVE-2018-8283], [CVE-2018-8286], [CVE-2018-8287], [CVE-2018-8288], [CVE-2018-8290], [CVE-2018-8291], [CVE-2018-8294], [CVE-2018-8298]
chakrabot
pushed a commit
that referenced
this pull request
Jul 10, 2018
Merge pull request #5444 from atulkatti:servicing/1807_1.10 JULY 2018 Security Update that addresses the following issues in ChakraCore.dll: [CVE-2018-8275], [CVE-2018-8276], [CVE-2018-8279], [CVE-2018-8280], [CVE-2018-8283], [CVE-2018-8286], [CVE-2018-8287], [CVE-2018-8288], [CVE-2018-8290], [CVE-2018-8291], [CVE-2018-8294], [CVE-2018-8298]
This was referenced Nov 29, 2021
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JULY 2018 Security Update that addresses the following issues in ChakraCore.dll:
[CVE-2018-8275], [CVE-2018-8276], [CVE-2018-8279], [CVE-2018-8280], [CVE-2018-8283], [CVE-2018-8286], [CVE-2018-8287], [CVE-2018-8288], [CVE-2018-8290], [CVE-2018-8291], [CVE-2018-8294], [CVE-2018-8298]