fix handling decimal type with no decimal with always encrypted #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 36fef13 on v-kaywon:changeUTC into ** on Microsoft:dev**. |
|
Changes Unknown when pulling e612621 on v-kaywon:changeUTC into ** on Microsoft:dev**. |
yitam
reviewed
Sep 21, 2017
| @@ -48,7 +49,7 @@ foreach ( $dataTypes as $dataType ) { | |||
| if ( $compatType == $sqlType ) | |||
| $isCompat = true; | |||
| } | |||
| if ( $isCompat ) | |||
| if ( $isCompat && sqlsrv_errors()[0]['SQLSTATE'] == 22018 ) | |||
There was a problem hiding this comment.
Under what conditions would this error occur, if the data types are supposedly compatible?
There was a problem hiding this comment.
I've added a comment on this in the test for clarification. This error occurs when the datatypes between sqltype and column datatype is not compatible (i.e., implicit conversion is not allowed in SQL Server)
|
Changes Unknown when pulling d72504b on v-kaywon:changeUTC into ** on Microsoft:dev**. |
david-puglielli
approved these changes
Sep 22, 2017
yitam
approved these changes
Sep 25, 2017
|
Changes Unknown when pulling 0d5bd24 on v-kaywon:changeUTC into ** on Microsoft:dev**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.