Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw the initial batchException #458

Merged
merged 2 commits into from
Sep 1, 2017

Conversation

AfsanehR-zz
Copy link
Contributor

Fixes #457 . In case of batch updates, driver hides the custom trigger error messages.

@codecov-io
Copy link

codecov-io commented Aug 23, 2017

Codecov Report

Merging #458 into dev will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #458      +/-   ##
============================================
+ Coverage     46.33%   46.35%   +0.02%     
+ Complexity     2202     2201       -1     
============================================
  Files           108      108              
  Lines         25248    25268      +20     
  Branches       4170     4177       +7     
============================================
+ Hits          11698    11714      +16     
+ Misses        11531    11529       -2     
- Partials       2019     2025       +6
Flag Coverage Δ Complexity Δ
#JDBC41 46.12% <50%> (-0.05%) 2187 <0> (-7)
#JDBC42 46.26% <50%> (+0.16%) 2200 <0> (+11) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.57% <50%> (+0.9%) 165 <0> (+4) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.26% <0%> (-0.45%) 104% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.49% <0%> (-0.37%) 239% <0%> (-3%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.84% <0%> (-0.08%) 274% <0%> (-2%)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 29.7% <0%> (ø) 49% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (ø) 16% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.36% <0%> (ø) 130% <0%> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 29.19% <0%> (+0.03%) 90% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e087c...1892ee1. Read the comment docs.

@AfsanehR-zz AfsanehR-zz added this to the 6.3.2 milestone Aug 28, 2017
@AfsanehR-zz AfsanehR-zz merged commit b7fee51 into microsoft:dev Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants