Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error message #635

Merged
merged 4 commits into from
Mar 6, 2018
Merged

Unexpected error message #635

merged 4 commits into from
Mar 6, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Feb 23, 2018

Added additional information to the error messages causing "Unexpected Big Int Value". Also added fall-through logic to deal with issue #608.

To debug a random mismatch error which can't be reproduced locally.
don't attempt mismatch logic if there's no columns to look for. fall through to sql server and do a lookup on the first column.
@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #635 into dev will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #635      +/-   ##
===========================================
+ Coverage     46.46%   46.5%   +0.03%     
- Complexity     2221    2223       +2     
===========================================
  Files           109     109              
  Lines         25409   25411       +2     
  Branches       4187    4188       +1     
===========================================
+ Hits          11807   11818      +11     
+ Misses        11568   11559       -9     
  Partials       2034    2034
Flag Coverage Δ Complexity Δ
#JDBC42 46.43% <0%> (+0.11%) 2220 <0> (+3) ⬆️
#JDBC43 46.34% <0%> (-0.04%) 2219 <0> (+2)
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 30.44% <0%> (-0.05%) 96 <0> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.03% <0%> (-0.47%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.61% <0%> (-0.07%) 239% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (ø) 16% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.95% <0%> (+0.2%) 242% <0%> (+1%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.75% <0%> (+0.21%) 42% <0%> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.53% <0%> (+0.24%) 155% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.2% <0%> (+0.3%) 0% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.57% <0%> (+0.65%) 89% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.44% <0%> (+0.85%) 63% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd4ee4...08bd1e6. Read the comment docs.

@rene-ye rene-ye added this to the 6.5.0 milestone Feb 27, 2018
@rene-ye rene-ye merged commit 923a6f4 into microsoft:dev Mar 6, 2018
@rene-ye rene-ye deleted the UnexpectedErrMsg branch March 6, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants