-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add | DataSourceFactory and OSGI Framework APIs #700
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #700 +/- ##
============================================
+ Coverage 49.87% 49.98% +0.11%
- Complexity 2887 2912 +25
============================================
Files 118 120 +2
Lines 28012 28090 +78
Branches 4673 4688 +15
============================================
+ Hits 13972 14042 +70
+ Misses 11786 11768 -18
- Partials 2254 2280 +26
Continue to review full report at Codecov.
|
Hi @laeubi, sorry it's been awhile since this thread's been updated. I've created a PR on your branch with some changes. If you could merge the changes, the team can start the review process for this PR to go into the next preview release. |
Issue699
@rene-ye I have merged your changes, thanks for taking this PR into account for the next preview release. |
src/main/java/com/microsoft/sqlserver/jdbc/osgi/SQLServerDataSourceFactory.java
Outdated
Show resolved
Hide resolved
Changes regarding reviews
Fix | Added the warning message to the resource bundle
…driver also attempts to stop the timeout poller
…ing the driver also attempts to stop the timeout poller" This reverts commit 6deabc4.
Register driver explicitly in start() to avoid Classloader conflicts
Add | Deregister driver upon stop()
@cheenamalhotra @laeubi @rene-ye We were using mssql-jdbc-6.2.2.jar for implementing RDBMK support in Adobe AEM. No we are testing with the latest mssql-jdbc-8.2.2.jar but this bundle remains in installed state with unresolved dependency for org.osgi.service.jdbc.jar The OSGI support was added through this PR. Can you please suggest why is this dependency not embedded and we have to additionally install org.osgi.service.jdbc.jar? |
@sonagupt org.osgi.service.jdbc is a package that must be provided by your container (its part of the OSGI-compendium service definition) this depends a little bit on your setup. |
Provides an implementation of the DataSourceFactory as well as an Activator that publishes the service.