Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add | DataSourceFactory and OSGI Framework APIs #700

Merged
merged 39 commits into from
Jan 2, 2019

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented May 17, 2018

Provides an implementation of the DataSourceFactory as well as an Activator that publishes the service.

@msftclas
Copy link

msftclas commented May 17, 2018

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented May 17, 2018

Codecov Report

Merging #700 into dev will increase coverage by 0.11%.
The diff coverage is 53.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #700      +/-   ##
============================================
+ Coverage     49.87%   49.98%   +0.11%     
- Complexity     2887     2912      +25     
============================================
  Files           118      120       +2     
  Lines         28012    28090      +78     
  Branches       4673     4688      +15     
============================================
+ Hits          13972    14042      +70     
+ Misses        11786    11768      -18     
- Partials       2254     2280      +26
Flag Coverage Δ Complexity Δ
#JDBC42 49.54% <53.16%> (+0.14%) 2871 <15> (+23) ⬆️
#JDBC43 49.89% <53.16%> (+0.14%) 2908 <15> (+28) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...qlserver/jdbc/osgi/SQLServerDataSourceFactory.java 35.18% <35.18%> (ø) 7 <7> (?)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 81.61% <90.9%> (+1.52%) 32 <5> (+7) ⬆️
...a/com/microsoft/sqlserver/jdbc/osgi/Activator.java 92.85% <92.85%> (ø) 3 <3> (?)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.72% <0%> (-1.09%) 112% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 42.7% <0%> (-0.23%) 310% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.55% <0%> (-0.13%) 256% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.19% <0%> (-0.07%) 0% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 65.33% <0%> (ø) 64% <0%> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850675e...d24ae68. Read the comment docs.

@ulvii ulvii added this to the 7.1.4 milestone Dec 4, 2018
@rene-ye
Copy link
Member

rene-ye commented Dec 10, 2018

Hi @laeubi, sorry it's been awhile since this thread's been updated. I've created a PR on your branch with some changes. If you could merge the changes, the team can start the review process for this PR to go into the next preview release.

@laeubi
Copy link
Contributor Author

laeubi commented Dec 11, 2018

@rene-ye I have merged your changes, thanks for taking this PR into account for the next preview release.

@rene-ye rene-ye changed the title Implementation for #699 Add | DataSourceFactory and OSGI Framework APIs Dec 11, 2018
pom.xml Outdated Show resolved Hide resolved
rene-ye
rene-ye previously approved these changes Dec 14, 2018
rene-ye and others added 3 commits December 18, 2018 11:45
…driver also attempts to stop the timeout poller
…ing the driver also attempts to stop the timeout poller"

This reverts commit 6deabc4.
@rene-ye rene-ye dismissed stale reviews from peterbae and themself via d75ebc5 December 18, 2018 21:01
@ulvii
Copy link
Contributor

ulvii commented Dec 19, 2018

Hi @laeubi,

Please also merge the following PR created against your branch: laeubi#5.

@sonagupt
Copy link

sonagupt commented Apr 30, 2020

@cheenamalhotra @laeubi @rene-ye We were using mssql-jdbc-6.2.2.jar for implementing RDBMK support in Adobe AEM. No we are testing with the latest mssql-jdbc-8.2.2.jar but this bundle remains in installed state with unresolved dependency for org.osgi.service.jdbc.jar The OSGI support was added through this PR. Can you please suggest why is this dependency not embedded and we have to additionally install org.osgi.service.jdbc.jar?

@laeubi
Copy link
Contributor Author

laeubi commented Apr 30, 2020

@sonagupt org.osgi.service.jdbc is a package that must be provided by your container (its part of the OSGI-compendium service definition) this depends a little bit on your setup.
Even though its possible to embed (and reexported) this into the jar, licensing issues must be considered and from an OSGi point of view its generally better to provide such API packages as extra bundles as these are likely to be shared by many clients/provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants