-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OffsetDateTime to be passed as 'type' in ResultSet.getObject() #830
Merged
lilgreenbird
merged 4 commits into
microsoft:dev
from
harawata:getobject-with-offsetdatetime
Dec 22, 2018
Merged
Add support for OffsetDateTime to be passed as 'type' in ResultSet.getObject() #830
lilgreenbird
merged 4 commits into
microsoft:dev
from
harawata:getobject-with-offsetdatetime
Dec 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #830 +/- ##
===========================================
+ Coverage 48.4% 48.69% +0.29%
- Complexity 2790 2819 +29
===========================================
Files 116 118 +2
Lines 27878 27890 +12
Branches 4651 4646 -5
===========================================
+ Hits 13493 13581 +88
+ Misses 12173 12120 -53
+ Partials 2212 2189 -23
Continue to review full report at Codecov.
|
This was referenced Oct 14, 2018
ulvii
reviewed
Dec 11, 2018
ulvii
reviewed
Dec 11, 2018
Allow retrieving OffsetTime out of DATETIMEOFFSET column.
rene-ye
approved these changes
Dec 17, 2018
ulvii
approved these changes
Dec 19, 2018
cheenamalhotra
approved these changes
Dec 19, 2018
lilgreenbird
approved these changes
Dec 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
PreparedStatement.setObject(int, Object)
already supportsjava.time.OffsetDateTime
, it may make sense.This was proposed in #749 (comment) , but no work has been done, it seems.