Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify boolean expressions #857

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Oct 26, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #857 into dev will decrease coverage by 0.02%.
The diff coverage is 23.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #857      +/-   ##
============================================
- Coverage     48.69%   48.67%   -0.03%     
  Complexity     2797     2797              
============================================
  Files           116      116              
  Lines         27875    27875              
  Branches       4650     4650              
============================================
- Hits          13575    13567       -8     
- Misses        12095    12098       +3     
- Partials       2205     2210       +5
Flag Coverage Δ Complexity Δ
#JDBC42 48.17% <23.52%> (-0.05%) 2753 <4> (-1)
#JDBC43 48.59% <23.52%> (+0.01%) 2792 <4> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.96% <0%> (ø) 212 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.16% <0%> (-0.14%) 0 <0> (ø)
...main/java/com/microsoft/sqlserver/jdbc/Column.java 34.73% <0%> (ø) 35 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.56% <0%> (ø) 66 <0> (ø) ⬇️
...microsoft/sqlserver/jdbc/FailOverMapSingleton.java 13.79% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.12% <0%> (-0.21%) 64 <0> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.42% <16.66%> (+0.43%) 90 <0> (+1) ⬆️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.09% <23.07%> (ø) 335 <4> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.79% <66.66%> (+0.12%) 264 <0> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b331c3b...99c7f78. Read the comment docs.

@simon04
Copy link
Contributor Author

simon04 commented Oct 30, 2018

@rene-ye, thanks a lot for your detailed and applicable review. I addressed your suggestions and amended+rebased my commit.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
@cheenamalhotra cheenamalhotra merged commit 2048aae into microsoft:dev Nov 21, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
ulvii added a commit that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants