Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube Fixes to abide rules + Warnings fixed #933

Merged
merged 5 commits into from
Jan 14, 2019

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@cheenamalhotra cheenamalhotra added this to the 7.2.0 milestone Jan 14, 2019
@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #933 into dev will increase coverage by 0.17%.
The diff coverage is 66.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #933      +/-   ##
============================================
+ Coverage     50.34%   50.52%   +0.17%     
+ Complexity     2919     2918       -1     
============================================
  Files           120      120              
  Lines         28094    28009      -85     
  Branches       4697     4682      -15     
============================================
+ Hits          14144    14151       +7     
+ Misses        11646    11560      -86     
+ Partials       2304     2298       -6
Flag Coverage Δ Complexity Δ
#JDBC42 50.01% <65.13%> (+0.18%) 2873 <9> (+1) ⬆️
#JDBC43 50.44% <66.01%> (+0.14%) 2916 <9> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...a/com/microsoft/sqlserver/jdbc/SQLServerNClob.java 100% <ø> (ø) 7 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SqlFedAuthToken.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...erverColumnEncryptionCertificateStoreProvider.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...sqlserver/jdbc/SQLServerBulkBatchInsertRecord.java 30.71% <ø> (ø) 18 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerSavepoint.java 90% <ø> (ø) 10 <0> (ø) ⬇️
...icrosoft/sqlserver/jdbc/SQLServerXAConnection.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/StreamRetValue.java 75% <ø> (ø) 5 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 29.51% <ø> (ø) 100 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java 45.52% <ø> (ø) 27 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerBulkCommon.java 47.22% <ø> (ø) 5 <0> (ø) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38e970...db603db. Read the comment docs.

rene-ye
rene-ye previously approved these changes Jan 14, 2019
@cheenamalhotra cheenamalhotra merged commit 9c5cc97 into microsoft:dev Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants