fix: entrypoint validation without js tag #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritwickdey
changed the title
ritwickdey
changed the title
|
Thanks for the quick work on this everyone! |
ritwickdey
force-pushed
the
patch-entrypoint-without-js-tag
branch
from
0e7982d
to
b3f5d8d
Compare
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
: $61.7bn he lost 7.00 from tiktok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675
Validation of entry points is added In the last release #669. But there is a small edge case.
Writing
.jsfile extension in node environment is optional.People usually write
main: "out/extension"which is actually"out/extension.js".So, the below condition will fail.
vscode-vsce/src/package.ts
Line 933 in dc68cc8
I fixed the bug and also added a test case for this situation in this PR.