Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML from code gets rendered in VS Code #380

Closed
JonnyBurger opened this issue Sep 10, 2018 · 2 comments
Closed

HTML from code gets rendered in VS Code #380

JonnyBurger opened this issue Sep 10, 2018 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug description page

Comments

@JonnyBurger
Copy link

Above you can see how the PR looks in Github, Below you can see how it looks in VS Code..
Surprisingly, a button gets rendered 😱

bildschirmfoto 2018-09-10 um 17 54 23

The HTML in question:
<button *ngIf="isEditingAllowed" class="btn btn-primary big" [disabled]="projectForm.invalid" (click)="save(projectForm)">Save changes</button>

@RMacfarlane RMacfarlane added bug Issue identified by VS Code Team member as probable bug description page labels Sep 10, 2018
@rebornix
Copy link
Member

Good catch, we should add filters for markdown renderer.

@connorshea
Copy link

See also #322, I have another example of this there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug description page
Projects
None yet
Development

No branches or pull requests

4 participants