Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save All - keyboard shortcut should use VS binding #11433

Closed
shammelburg opened this issue Sep 2, 2016 · 3 comments
Closed

Save All - keyboard shortcut should use VS binding #11433

shammelburg opened this issue Sep 2, 2016 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality ux User experience issues
Milestone

Comments

@shammelburg
Copy link

  • VSCode Version: 1.4.0
  • OS Version: Windows 10

Visual Studio (IDE) has the Save All keyboard shortcut of (Ctrl+Shift+S), the same shortcut is available in code but it actions the Save As... function.

Can you apply the same to VS Code? I use both daily, like many other developers.

It would be nice to keep the same functionality between both Microsoft products.

@bpasero
Copy link
Member

bpasero commented Sep 3, 2016

@shammelburg keybindings can be changed via settings. The current keybinding was inspired from Sublime and Atom and has been like this from day one.

Marking as UX issue.

@bpasero bpasero changed the title Save All - keyboard shortcut Save All - keyboard shortcut should use VS binding Sep 3, 2016
@bpasero bpasero added ux User experience issues feature-request Request for new features or functionality labels Sep 3, 2016
@bpasero bpasero added this to the Backlog milestone Sep 3, 2016
@bpasero bpasero removed their assignment Sep 3, 2016
@chrmarti
Copy link
Contributor

The main problem is that there is no keybinding by default, yet we propagate a UX where refactorings and global replace open all affected files, apply the changes and leave the editors dirty. In that situation I often want to use Save All and I think we should provide a keybinding by default. What about using the same as Atom/Sublime use: Alt+Cmd+S?

@shammelburg
Copy link
Author

@chrmarti I think that'll be great. Having this feature as a default keybinding would help a lot.

@chrmarti chrmarti self-assigned this Oct 4, 2016
@chrmarti chrmarti modified the milestones: October 2016, Backlog Oct 4, 2016
waderyan pushed a commit that referenced this issue Oct 6, 2016
Bind Save All to Alt+Ctrl+S (fixes #11433)
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants