Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "find in selection" by default when replace executed against a multi-line selection #17560

Closed
frostius opened this issue Dec 19, 2016 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality ux User experience issues
Milestone

Comments

@frostius
Copy link

When doing a replace (in current file) and there is a selection that spans lines, the "find in selection" ought to be enabled by default.

  1. I believe this is standard behavior in most other programmer's editors (visual studio, intellij, textpad++)
  2. Ignoring the current context (multiple line selection) when doing a search makes no sense - why else would the use have made the selection then pressed replace?
  3. For me at least, its pretty rare that I want to do a global search/replace. This is certainly the least likely use case
@egamma egamma added editor-find Editor find operations editor labels Dec 20, 2016
@alexdima alexdima added the ux User experience issues label Mar 2, 2017
@alexdima alexdima added this to the Backlog milestone Mar 2, 2017
@rebornix rebornix assigned rebornix and unassigned alexdima May 6, 2017
@rebornix rebornix modified the milestones: May 2017, Backlog May 6, 2017
@rebornix rebornix added the feature-request Request for new features or functionality label May 6, 2017
@rebornix
Copy link
Member

rebornix commented May 8, 2017

We have a bunch of users who don't want to have this by default but we definitely can have a setting to define the default behavior, maybe named as autoFindInSelection or so. Let's track it in #15148.

@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label May 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants