Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] Follow Link in Multi Root Workspace #38469

Closed
NicoCevallos opened this issue Nov 16, 2017 · 7 comments
Closed

[html] Follow Link in Multi Root Workspace #38469

NicoCevallos opened this issue Nov 16, 2017 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verification-found Issue verification failed verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@NicoCevallos
Copy link

NicoCevallos commented Nov 16, 2017

  • VSCode Version: Code 1.18.0 (dcee220, 2017-11-08T21:22:49.932Z)
  • OS Version: Windows_NT x64 10.0.15063

Into a HTML file, if I add the "base" tag pointing to "/" it should refer to the current root workspace instead the first folder in the folder arrays of the configuration file.

Using a Workspace Configuration File like this:
image

And having file distribution and a HTML file like this:
image

Step 1: Follow the link to "manifest.json" file (Ctrl + Click)

Expected Result:
Open the file using the Root Workspace where the HTML file is placed (folder A).

Actual Result:
VS Code tries to open the file using the first Root Workspace folder in the list (folder B), and show the following error message:
image

@bpasero bpasero added workbench-multiroot Multi-root (multiple folders) issues and removed workbench labels Nov 16, 2017
@bpasero
Copy link
Member

bpasero commented Nov 16, 2017

@NicoCevallos I cannot reproduce this issue, for me it goes to the correct folder. Do you have any extensions installed? Does it reproduce if you run "code --disable-extensions"?

@bpasero bpasero added info-needed Issue requires more information from poster *not-reproducible Issue cannot be reproduced by VS Code Team member as described labels Nov 16, 2017
@NicoCevallos
Copy link
Author

I reproduced the issue without extensions before to report the issue.
Could you share the Workspace Configuration File and the HTML file you are using to reproduce it?
Please take into account my Workspace Configuration File has the folders in a no alphabetical order and the HTML file has the tag, without the tag it is not reproducible.

@bpasero
Copy link
Member

bpasero commented Nov 16, 2017

@NicoCevallos I tried with that exact setup, I cannot reproduce, sorry.

@NicoCevallos
Copy link
Author

Hi @bpasero
I took another computer, and I could reproduce the issue following the same steps I described.
Please try opening the "test.code-workspace" file into the following zip file.
test.zip

@bpasero bpasero removed the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Nov 20, 2017
@bpasero bpasero assigned aeschli and unassigned bpasero Nov 20, 2017
@bpasero bpasero added the html HTML support issues label Nov 20, 2017
@bpasero
Copy link
Member

bpasero commented Nov 20, 2017

Ok I can reproduce. It looks to me like an issue from the link provider (HTML).

@aeschli aeschli changed the title Follow Link in Multi Root Workspace [html] Follow Link in Multi Root Workspace Nov 20, 2017
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 20, 2017
@aeschli aeschli added this to the November 2017 milestone Nov 20, 2017
@NicoCevallos
Copy link
Author

Thanks guys!

@roblourens
Copy link
Member

Insiders:

image

@roblourens roblourens reopened this Dec 6, 2017
@roblourens roblourens added the verification-found Issue verification failed label Dec 6, 2017
@aeschli aeschli modified the milestones: November 2017, December 2017 Dec 7, 2017
@roblourens roblourens added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verification-found Issue verification failed verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

5 participants