Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-96: use of EditorPlugin.new() results in script error since beta16 #96

Closed
MikeSchulze opened this issue Jan 28, 2023 · 5 comments · Fixed by #97
Closed

GD-96: use of EditorPlugin.new() results in script error since beta16 #96

MikeSchulze opened this issue Jan 28, 2023 · 5 comments · Fixed by #97
Assignees
Labels
bug Something isn't working critical A problem with a critical error must be fixed in the near future if possible godot related issue Its a bug by Godot engine and can't be fixed by GdUnit
Milestone

Comments

@MikeSchulze
Copy link
Owner

The used Godot version:
v4.0.beta16.official [518b9e580]

OS including version:
ALL

Describe the bug
We use on some places EditorPlugin.new() to access the editor interface.
But this is broken since beta15/beta16
There is no static accessor of the EditorInterface and needs the plugin instance to access.

Steps to Reproduce

@tool
extends Control

func _ready():
	var plugin := EditorPlugin.new()

results in
Parser Error: Native class "EditorPlugin" cannot be constructed as it is abstract.

Godot Issue
godotengine/godot#68685

Minimal reproduction project:

@MikeSchulze MikeSchulze added bug Something isn't working godot related issue Its a bug by Godot engine and can't be fixed by GdUnit critical A problem with a critical error must be fixed in the near future if possible labels Jan 28, 2023
@MikeSchulze MikeSchulze added this to the V4.1.0 milestone Jan 28, 2023
@MikeSchulze MikeSchulze self-assigned this Jan 28, 2023
@MikeSchulze MikeSchulze changed the title use of EditorPlugin.new() results in script error since beta16 GD-96: use of EditorPlugin.new() results in script error since beta16 Jan 28, 2023
@MikeSchulze MikeSchulze linked a pull request Jan 28, 2023 that will close this issue
@JustMog
Copy link

JustMog commented Oct 3, 2023

not fixed as of 4.1.1

@MikeSchulze
Copy link
Owner Author

What do you want to tell me? Is there a current problem with GdUnit4?

@JustMog
Copy link

JustMog commented Oct 4, 2023

yes bug.zip

@MikeSchulze
Copy link
Owner Author

Your code has nothing to do with the GdUnit4 plugin.
If you want to write your own plugin, you have to follow the official documentation.
https://docs.godotengine.org/en/latest/tutorials/plugins/editor/making_plugins.html

@JustMog
Copy link

JustMog commented Oct 5, 2023

oh i got here from the godot repo somehow without realising i'd left it, no idea how that happened, sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical A problem with a critical error must be fixed in the near future if possible godot related issue Its a bug by Godot engine and can't be fixed by GdUnit
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants