Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-121: Improve AssertSignal by adding a StartMonitoring method to make it more prominent #121

Closed
MikeSchulze opened this issue Jun 14, 2024 · 0 comments · Fixed by #122
Closed

GD-121: Improve AssertSignal by adding a StartMonitoring method to make it more prominent #121

MikeSchulze opened this issue Jun 14, 2024 · 0 comments · Fixed by #122
Assignees
@MikeSchulze
Labels
enhancement New feature or request gdunit4.api Issue is related to the `gdunit4.api`
Milestone
v4.2.5

Comments

@MikeSchulze
Copy link
Owner

Is your feature request related to a problem? Please describe.
On the GDScript API we have the signal monitor
https://mikeschulze.github.io/gdUnit4/advanced_testing/signals/#monitor-signals

But is missing in the C# API

Describe the solution you'd like
Provide the signal monitor as described in the documentation

Describe alternatives you've considered
n/a
Additional context
The monitor is already implemented but has no public access point.
api/src/core/signals/GodotSignalCollector.cs
@MikeSchulze MikeSchulze added enhancement New feature or request gdunit4.api Issue is related to the `gdunit4.api` labels Jun 14, 2024
@MikeSchulze MikeSchulze added this to the v4.2.5 milestone Jun 14, 2024
@MikeSchulze MikeSchulze self-assigned this Jun 14, 2024
@MikeSchulze MikeSchulze changed the title Add signal monitor to collect signals over the test execution time GD-121: Add signal monitor to collect signals over the test execution time Jun 14, 2024
@MikeSchulze MikeSchulze linked a pull request Jun 14, 2024 that will close this issue
GD-121: Improve AssertSignal by adding a StartMonitoring method #122
Merged
@MikeSchulze MikeSchulze changed the title GD-121: Add signal monitor to collect signals over the test execution time GD-121: Improve AssertSignal by adding a StartMonitoring method to make it more prominent Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
enhancement New feature or request gdunit4.api Issue is related to the `gdunit4.api`
Projects
None yet
Milestone
v4.2.5
Development

Successfully merging a pull request may close this issue.

GD-121: Improve AssertSignal by adding a StartMonitoring method MikeSchulze/gdUnit4Net
1 participant
@MikeSchulze