Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Guess Mode (or use another better name) #236

Closed
lllyasviel opened this issue Feb 20, 2023 · 3 comments
Closed

[Feature request] Guess Mode (or use another better name) #236

lllyasviel opened this issue Feb 20, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@lllyasviel
Copy link
Collaborator

lllyasviel commented Feb 20, 2023

By putting control map in unconditional guidance side and scale the U-net skip connections, we can enforce the encoder to recognize the contents in control maps.

See also:
Examples - see updated readme in https://github.com/lllyasviel/ControlNet (Section: Guess Mode / Non-Prompt Mode)
Implementation - lllyasviel/ControlNet@005008b

Note that this may be experimental. Let me know what you think. This feature is not very eager and perhaps we can consider test it with some experiments first. Let us put it in a secondary priority.

Thank you for the great work of maintaining the webui.

@lllyasviel
Copy link
Collaborator Author

also, to predict unconditional eps, perhaps we may also try to ignore the unet adding rather than using zero as control map, to save computation. but we may experiment a bit more about it.

@Mikubill Mikubill added the enhancement New feature or request label Feb 20, 2023
@Mikubill
Copy link
Owner

Mikubill commented Feb 20, 2023

Quick test shows different cfg-alike method will produce small bias:

by using zero as control net input
by ignore control map on uncond
base

All generation use (cfg3, no-prompt) preset.
Currently implemented in extension is the latter. If former option provides better quality I will switch to it.

@lllyasviel
Copy link
Collaborator Author

cool! perhaps ignoring control map on uncond is better considering some controls do not support zeros as uncond, like seg or normal map. ignoring on uncond should be better for these cases. let me also update main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants