Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Use current mask upload UI for effective region mask input (Attn Mask) #2829

Closed
huchenlei opened this issue Apr 30, 2024 · 1 comment · Fixed by #2830
Closed
Assignees

Comments

@huchenlei
Copy link
Collaborator

SD Forge has the mask upload UI for effective region mask. It can be confusing if we have the UI doing something else here. Since we recently have effective region mask support implemeneted in #2785 and #2818. We should sync the mask upload behaviour with SD Forge.

BTW, I found the option can be a good compliment of the region control UI, as it gives users fine grained control on mask. Here is a potential usage example: https://www.youtube.com/watch?v=CSEnlkXHoIA&t=47s&pp=ygULQWNhZGVtaWEgU0Q%3D

@huchenlei huchenlei self-assigned this Apr 30, 2024
@huchenlei
Copy link
Collaborator Author

Related discussion #2793.

@huchenlei huchenlei pinned this issue May 1, 2024
@huchenlei huchenlei mentioned this issue May 20, 2024
1 task
@sdbds sdbds unpinned this issue Jul 15, 2024
@sdbds sdbds pinned this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant