Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ManagedCluster CRD confusing points #364

Closed
a13x5 opened this issue Sep 20, 2024 · 1 comment · Fixed by #446
Closed

Fix ManagedCluster CRD confusing points #364

a13x5 opened this issue Sep 20, 2024 · 1 comment · Fixed by #446
Assignees

Comments

@a13x5
Copy link
Contributor

a13x5 commented Sep 20, 2024

I noticed several issues with the ManagedCluster CR:

  1. Name ManagedCluster clashes with the resource ManagedCluster of containerservice.azure.com/v1api20210501 which is a part of Azure provider. This means that user can't execute kubectl get managedcluster and has to user the full name kubectl get managedcluster.v1alpha1.hmc.mirantis.com
  2. Short names of the ManagedCluster are hmc-deploy and deploy which make confusion even more.

The task

Replace short names to be similar to the full name. In the docs if ManagedCluster resource is mentioned in scope of kubectl commands it should referenced by a full name with group and version (managedcluster.v1alpha1.hmc.mirantis.com).

@a13x5
Copy link
Contributor Author

a13x5 commented Oct 7, 2024

Reopen, since docs aren't ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant