Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local scaling with multiple input based on far interaction #928

Open
nilshof01 opened this issue Sep 19, 2024 · 5 comments
Open

local scaling with multiple input based on far interaction #928

nilshof01 opened this issue Sep 19, 2024 · 5 comments
Assignees
Labels
Status: In Progress Issue is actively being worked on. Status: In Review A pull request fixing the issue has been submitted and is ready for review. Type: Bug A problem with an existing feature that can be fixed with the next patched release.

Comments

@nilshof01
Copy link

Describe the bug

I have one game object in my scene which has an object manipulator attached. When i want to scale or move it with the controllers (Meta quest 3) everything works fine. Then when I switch to my hands, I can move the object by pinching but as soon as I want to rescale it with both hands the scene crashes and the following error appears:
'''
transform.localScale assign attempt for '1AFB_bounding_sphere' is not valid. Input localScale is { NaN, NaN, NaN }.
UnityEngine.Transform:set_localScale (UnityEngine.Vector3)
MixedReality.Toolkit.SpatialManipulation.ObjectManipulator:ApplyTargetTransform () (at ./Library/PackageCache/org.mixedrealitytoolkit.spatialmanipulation@5fe191610f47/ObjectManipulator/ObjectManipulator.cs:882)
MixedReality.Toolkit.SpatialManipulation.ObjectManipulator:ProcessInteractable (UnityEngine.XR.Interaction.Toolkit.XRInteractionUpdateOrder/UpdatePhase) (at ./Library/PackageCache/org.mixedrealitytoolkit.spatialmanipulation@5fe191610f47/ObjectManipulator/ObjectManipulator.cs:848)
UnityEngine.XR.Interaction.Toolkit.XRInteractionManager:Update ()
'''
Here, "1AFB_bounding_sphere" is the name of my object which has the object manipulator attached.

To reproduce

Hardware:

  • Meta quest 3
  • controllers
  • your hands

Software:

  • XR Hands 1.3.0
  • XR Interaction Toolkit 3.0.3
  • Unity OpenXR Meta 1.0.1
  • Universal RP 14.0.10
  • MRTK Input 4.0.0-pre.1
  • MRTK Spatial Manipulation 4.0.0-pre.1
  • MRTK Standard Assets 3.2.0
  • MRTK Tools 3.0.4
  • MRTK Core Definitions 4.0.0-pre.1
  • MK UX Components 4.0.0-pre.1
  • MRTK UX Components (Non-Canvas) 4.0.0-pre.1
  • MRTK Extended Assets 3.0.3
  • MRTK Diagnostics 3.0.2
  • AR Foundation 5.1.5

Steps to reproduce the behavior:

My XR rig is basically copied from the HandsdemoScene under: Assets/Samples/XR Interaction Toolkit/3.0.3/Hands Interaction Demo/HandsDemoScene.unity. My object has the following components:

  • MeshRenderer
  • MeshCollider
  • ObjectManipulator (with multiple selection mode and rotate about object center for near and far)

Run the scene and use both of your hands with pinching on the same object with the object manipulator to scale it.

Expected behavior

I would have expected no error.

Your setup (please complete the following information)

  • Unity Version 2022.3

Target platform (please complete the following information)

  • Meta quest 3 (Android)

Additional context

Add any other context about the problem here.

@nilshof01 nilshof01 added Needs: Triage Needs to be triaged. Type: Bug A problem with an existing feature that can be fixed with the next patched release. labels Sep 19, 2024
@AMollis AMollis added Needs: Repro Missing clear or consistent reproduction steps. and removed Needs: Triage Needs to be triaged. labels Sep 25, 2024
@AMollis
Copy link
Contributor

AMollis commented Sep 25, 2024

@whebertML to attempt repro steps to better understand if the issue only occurs on Quert 3.

@nilshof01
Copy link
Author

Hi, I just wanted to ask if the issue will be fixed in the next release. It seems like that or am I wrong?

@whebertML
Copy link
Contributor

@nilshof01, the fix is under review and should hopefully be merged in soon. So it should make it into the next version 4 preview release I would think, yes.

Also, feel free to test the fix locally and let us know if it works for you and your specific use case.

@whebertML whebertML added Status: In Review A pull request fixing the issue has been submitted and is ready for review. Status: In Progress Issue is actively being worked on. and removed Needs: Repro Missing clear or consistent reproduction steps. labels Oct 9, 2024
@nilshof01
Copy link
Author

Hi, yes it works now. Though, the rays coming from my hands are pointing to the same point, although it is scaling. Moreover, they are not pointing on the object or the point which I am pointing at. But I guess, that is an issue with the XR rig configuration...

@whebertML
Copy link
Contributor

@nilshof01 Hey, thanks for testing. And yes, the end of the rays appearing to point to the same position is just how the XRI3 rig's ray interactors work by default. If you were to switch to using the MRTK3 rig, our ray interactors ray ends at the point of ray intersection with the object collider instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Issue is actively being worked on. Status: In Review A pull request fixing the issue has been submitted and is ready for review. Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Development

No branches or pull requests

3 participants