Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Cache only option for Store 5 #457

Closed
matt-ramotar opened this issue Nov 2, 2022 · 5 comments · Fixed by #586
Closed

[Feature Request] Cache only option for Store 5 #457

matt-ramotar opened this issue Nov 2, 2022 · 5 comments · Fixed by #586
Labels
enhancement New feature or request
Milestone

Comments

@matt-ramotar
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Option to hit cache only

Describe the solution you'd like
Do not hit network on empty cache

Describe alternatives you've considered

  1. Force fetcher to fail fast
  2. Wrap Store and add custom observer

Additional context
From #store-core

@jsilva05
Copy link

Hi @matt-ramotar
Are there any plans to support this in the near future?

Thanks!

@matt-ramotar
Copy link
Collaborator Author

Hey there - Thanks for reaching out! @digitalbuddha is working on resolving the last remaining breaking changes to Store4. Once #559 goes in, we can add this along with #554 and #555. My ballpark estimate for merging these changes is mid July. Does that sound OK? Let us know if you need it sooner and we will do our best

@matt-ramotar matt-ramotar added this to the Store 5 milestone Jun 19, 2023
@jsilva05
Copy link

Thank you for the quick reply.

Sounds good! We started to migrate some of our usecases to store5 to see what would be the changes needed. We have a couple of cases where we need CacheOnly but we already have a workaround in place and we can keep using it until this is ready.

@wbrawner
Copy link
Contributor

Hi there! Is this under development? It seems that #559 was merged in some time ago. If it's not in progress, I'd be happy to take a look at it

@matt-ramotar
Copy link
Collaborator Author

Hey @wbrawner - No progress yet. Awesome! Happy to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants